[llvm] WIP: [Offload] Add testing for Offload program and kernel related entry points (PR #127803)

via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 06:37:02 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 71fd5288d28169cc4a6ae0bcf6c19a8130368936 c43356c8bafd592f7a518d1f8918cd50149ab670 --extensions hpp,inc,h,cpp,c -- offload/unittests/OffloadAPI/device_code/bar.c offload/unittests/OffloadAPI/device_code/foo.c offload/unittests/OffloadAPI/device_code/util.h offload/unittests/OffloadAPI/enqueue/olEnqueueDataCopy.cpp offload/unittests/OffloadAPI/enqueue/olEnqueueDataRead.cpp offload/unittests/OffloadAPI/enqueue/olEnqueueDataWrite.cpp offload/unittests/OffloadAPI/enqueue/olEnqueueKernelLaunch.cpp offload/unittests/OffloadAPI/enqueue/olEnqueueMemcpy.cpp offload/unittests/OffloadAPI/kernel/olCreateKernel.cpp offload/unittests/OffloadAPI/kernel/olReleaseKernel.cpp offload/unittests/OffloadAPI/kernel/olRetainKernel.cpp offload/unittests/OffloadAPI/kernel/olSetKernelArgValue.cpp offload/unittests/OffloadAPI/kernel/olSetKernelArgsData.cpp offload/unittests/OffloadAPI/memory/olMemAlloc.cpp offload/unittests/OffloadAPI/memory/olMemFree.cpp offload/unittests/OffloadAPI/program/olCreateProgram.cpp offload/unittests/OffloadAPI/program/olReleaseProgram.cpp offload/unittests/OffloadAPI/program/olRetainProgram.cpp offload/unittests/OffloadAPI/queue/olCreateQueue.cpp offload/unittests/OffloadAPI/queue/olFinishQueue.cpp offload/unittests/OffloadAPI/queue/olReleaseQueue.cpp offload/unittests/OffloadAPI/queue/olRetainQueue.cpp offload/liboffload/include/generated/OffloadAPI.h offload/liboffload/include/generated/OffloadEntryPoints.inc offload/liboffload/include/generated/OffloadFuncs.inc offload/liboffload/include/generated/OffloadImplFuncDecls.inc offload/liboffload/include/generated/OffloadPrint.hpp offload/liboffload/src/OffloadImpl.cpp offload/plugins-nextgen/common/include/GlobalHandler.h offload/plugins-nextgen/cuda/src/rtl.cpp offload/plugins-nextgen/host/src/rtl.cpp offload/tools/offload-tblgen/APIGen.cpp offload/tools/offload-tblgen/EntryPointGen.cpp offload/tools/offload-tblgen/PrintGen.cpp offload/tools/offload-tblgen/RecordTypes.hpp offload/unittests/OffloadAPI/common/Environment.cpp offload/unittests/OffloadAPI/common/Environment.hpp offload/unittests/OffloadAPI/common/Fixtures.hpp offload/unittests/OffloadAPI/platform/olPlatformInfo.hpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/offload/liboffload/src/OffloadImpl.cpp b/offload/liboffload/src/OffloadImpl.cpp
index 9bdb0567503..67f9a969343 100644
--- a/offload/liboffload/src/OffloadImpl.cpp
+++ b/offload/liboffload/src/OffloadImpl.cpp
@@ -530,8 +530,8 @@ ol_impl_result_t olCreateProgram_impl(ol_device_handle_t Device, void *ProgData,
       StringRef(reinterpret_cast<char *>(ProgData), ProgDataSize));
   __tgt_device_image DeviceImage{
       const_cast<char *>(ImageData->getBuffer().data()),
-      const_cast<char *>(ImageData->getBuffer().data()) + ProgDataSize,
-      nullptr, nullptr};
+      const_cast<char *>(ImageData->getBuffer().data()) + ProgDataSize, nullptr,
+      nullptr};
 
   ol_program_handle_t Prog = new ol_program_impl_t();
 
diff --git a/offload/unittests/OffloadAPI/device_code/bar.c b/offload/unittests/OffloadAPI/device_code/bar.c
index 457f7c99b61..5f0473e7d17 100644
--- a/offload/unittests/OffloadAPI/device_code/bar.c
+++ b/offload/unittests/OffloadAPI/device_code/bar.c
@@ -1,5 +1,3 @@
 #include "util.h"
 
-KERNEL void bar(int *out) {
-    out[get_thread_id_x()] = get_thread_id_x() + 1;
-}
+KERNEL void bar(int *out) { out[get_thread_id_x()] = get_thread_id_x() + 1; }
diff --git a/offload/unittests/OffloadAPI/device_code/foo.c b/offload/unittests/OffloadAPI/device_code/foo.c
index bbaac57c9d9..5e73713cbd9 100644
--- a/offload/unittests/OffloadAPI/device_code/foo.c
+++ b/offload/unittests/OffloadAPI/device_code/foo.c
@@ -1,5 +1,3 @@
 #include "util.h"
 
-KERNEL void foo(int *out) {
-    out[get_thread_id_x()] = get_thread_id_x();
-}
+KERNEL void foo(int *out) { out[get_thread_id_x()] = get_thread_id_x(); }
diff --git a/offload/unittests/OffloadAPI/kernel/olCreateKernel.cpp b/offload/unittests/OffloadAPI/kernel/olCreateKernel.cpp
index 1aaa87c8ae9..ff7fd3bc077 100644
--- a/offload/unittests/OffloadAPI/kernel/olCreateKernel.cpp
+++ b/offload/unittests/OffloadAPI/kernel/olCreateKernel.cpp
@@ -13,8 +13,9 @@
 using olCreateKernelTest = offloadProgramTest;
 
 TEST_F(olCreateKernelTest, Success) {
-//   std::shared_ptr<std::vector<char>> DeviceBin2;
-//   ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Platform, DeviceBin2));
+  //   std::shared_ptr<std::vector<char>> DeviceBin2;
+  //   ASSERT_TRUE(TestEnvironment::loadDeviceBinary("foo", Platform,
+  //   DeviceBin2));
 
   ol_kernel_handle_t Kernel = nullptr;
   ASSERT_SUCCESS(olCreateKernel(Program, "foo", &Kernel));
diff --git a/offload/unittests/OffloadAPI/kernel/olRetainKernel.cpp b/offload/unittests/OffloadAPI/kernel/olRetainKernel.cpp
index 8da12f8446d..20799072eb2 100644
--- a/offload/unittests/OffloadAPI/kernel/olRetainKernel.cpp
+++ b/offload/unittests/OffloadAPI/kernel/olRetainKernel.cpp
@@ -12,9 +12,7 @@
 
 using olRetainKernelTest = offloadKernelTest;
 
-TEST_F(olRetainKernelTest, Success) {
-  ASSERT_SUCCESS(olRetainKernel(Kernel));
-}
+TEST_F(olRetainKernelTest, Success) { ASSERT_SUCCESS(olRetainKernel(Kernel)); }
 
 TEST_F(olRetainKernelTest, InvalidNullHandle) {
   ASSERT_ERROR(OL_ERRC_INVALID_NULL_HANDLE, olRetainKernel(nullptr));

``````````

</details>


https://github.com/llvm/llvm-project/pull/127803


More information about the llvm-commits mailing list