[llvm] [ELFObject] Added dbgs() statement in removeSections() (PR #124692)

[James Henderson via llvm-commits]

https://github.com/jh7370 requested changes to this pull request.

Sorry for the delay in looking at this. I've taken a look now.

Please update the PR title and description to remove references to `dbgs()`, since that isn't what this change is doing.

Also, please add the new option to the documentation at `llvm/docs/CommandGuide/llvm-objcopy.rst` and the `llvm-strip` equivalent.

If you haven't already, please review the [LLVM coding standards](https://llvm.org/docs/CodingStandards.html), as there are a few places (mentioned inline) where you've not stuck to them.

Please also take a look at how llvm-objcopy and llvm-strip are tested in llvm/test/tools/llvm-objcopy. You should extend the existing tests for removing sections and symbols to include a case where `--verbose` is specified, to show that the expected output is printed (and no unexpected output is printed). I can assist with some guidance, if you can't figure it out yourself from existing behaviours. You may also want to look at tests of llvm-readobj etc that print things, to see how to check output in tests.

As @MaskRay has mentioned, the GNU objcopy/strip verbose option prints which files have been modified/copied. Please take a look at the existing GNU behaviour and add this functionality. If you would prefer to do that in a separate, subsequent PR, that's okay too. However, it is important, because without printing which file we're working on, when multiple files are being operated on (e.g. in an archive file, or multiple command-line inputs to llvm-strip), it's impossible to determine which file is referenced by a specific verbose output line (e.g. if multiple of the same named symbol exist in different objects, we need to know which ones the symbol was removed from).

https://github.com/llvm/llvm-project/pull/124692