[llvm] [globals-aa] Improved isNonEscapingGlobalNoAlias. (PR #127707)

[Eli Friedman via llvm-commits]

================
@@ -762,6 +763,18 @@ bool GlobalsAAResult::isNonEscapingGlobalNoAlias(const GlobalValue *GV,
       continue;
     }
 
+    // A non-addr-taken global cannot alias with any non-pointer value.
+    if (!Input->getType()->isPointerTy())
----------------
efriedma-quic wrote:

I have no idea why we don't forbid alias queries on non-pointers.  CC @nikic.

In any case, you can hoist this check out of the loop.

https://github.com/llvm/llvm-project/pull/127707