[llvm] [globals-aa] Improved isNonEscapingGlobalNoAlias. (PR #127707)

[Eli Friedman via llvm-commits]

================
@@ -762,6 +763,18 @@ bool GlobalsAAResult::isNonEscapingGlobalNoAlias(const GlobalValue *GV,
       continue;
     }
 
+    // A non-addr-taken global cannot alias with any non-pointer value.
+    if (!Input->getType()->isPointerTy())
----------------
efriedma-quic wrote:

How do we end up with a value that isn't a pointer here?  alias() itself should only be queried with pointers (it doesn't make sense to ask whether a non-pointer aliases anything).   And the recursive steps in isNonEscapingGlobalNoAlias should produce pointers if the input is a pointer.

https://github.com/llvm/llvm-project/pull/127707