[llvm] [AArch64][Build Attributes] Improve Parsing and Formatting (PR #126530)

Oliver Stannard via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 03:23:21 PST 2025


================
@@ -7947,7 +7947,12 @@ bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) {
     }
   }
   Parser.Lex();
-  // Parsing finished, check for trailing tokens.
+
+  // Parsing finished, hereafter only accept comments; otherwise no trailing
+  // tokens.
+  if (Parser.getTok().is(llvm::AsmToken::At)) {
----------------
ostannard wrote:

`@` isn't a comment for AArch64. We should probably use `//`, and I suspect that this code will be unnecessary if you do, because comments should be stripped out by the lexer.

https://github.com/llvm/llvm-project/pull/126530


More information about the llvm-commits mailing list