[llvm] AMDGPU: Remove redundant inline constant check (PR #127582)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 17 23:27:28 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
<details>
<summary>Changes</summary>
We don't really care of this is an inline constant, only if it
will be legal.
---
Full diff: https://github.com/llvm/llvm-project/pull/127582.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/SIFoldOperands.cpp (+2-4)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/SIFoldOperands.cpp b/llvm/lib/Target/AMDGPU/SIFoldOperands.cpp
index 999553bfaff38..7c08a21dea3b8 100644
--- a/llvm/lib/Target/AMDGPU/SIFoldOperands.cpp
+++ b/llvm/lib/Target/AMDGPU/SIFoldOperands.cpp
@@ -824,8 +824,7 @@ bool SIFoldOperandsImpl::tryToFoldACImm(
return false;
uint8_t OpTy = Desc.operands()[UseOpIdx].OperandType;
- if (OpToFold.isImm() && TII->isInlineConstant(OpToFold, OpTy) &&
- TII->isOperandLegal(*UseMI, UseOpIdx, &OpToFold)) {
+ if (OpToFold.isImm() && TII->isOperandLegal(*UseMI, UseOpIdx, &OpToFold)) {
UseMI->getOperand(UseOpIdx).ChangeToImmediate(OpToFold.getImm());
return true;
}
@@ -845,8 +844,7 @@ bool SIFoldOperandsImpl::tryToFoldACImm(
MachineOperand &UseOp = UseMI->getOperand(UseOpIdx);
if (!UseOp.getSubReg() && Def && TII->isFoldableCopy(*Def)) {
MachineOperand &DefOp = Def->getOperand(1);
- if (DefOp.isImm() && TII->isInlineConstant(DefOp, OpTy) &&
- TII->isOperandLegal(*UseMI, UseOpIdx, &DefOp)) {
+ if (DefOp.isImm() && TII->isOperandLegal(*UseMI, UseOpIdx, &DefOp)) {
UseMI->getOperand(UseOpIdx).ChangeToImmediate(DefOp.getImm());
return true;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/127582
More information about the llvm-commits
mailing list