[llvm] [SPIR-V] Ensure that a correct pointer type is deduced from the Value argument of OpAtomic* instructions (PR #127492)

[Dmitry Sidorov via llvm-commits]

================
@@ -934,9 +937,23 @@ bool SPIRVEmitIntrinsics::deduceOperandElementTypeCalledFunction(
       case SPIRV::OpAtomicUMax:
       case SPIRV::OpAtomicSMin:
       case SPIRV::OpAtomicSMax: {
-        KnownElemTy = getAtomicElemTy(GR, CI, Op);
+        KnownElemTy = isPointerTy(CI->getType()) ? getAtomicElemTy(GR, CI, Op)
+                                                 : CI->getType();
         if (!KnownElemTy)
           return true;
+        Uncomplete = isTodoType(Op);
+        Ops.push_back(std::make_pair(Op, 0));
+      } break;
+      case SPIRV::OpAtomicStore: {
+        if (CI->arg_size() < 4)
+          return true;
+        Value *ValOp = CI->getArgOperand(3);
+        KnownElemTy = isPointerTy(ValOp->getType())
+                          ? getAtomicElemTy(GR, CI, Op)
+                          : ValOp->getType();
+        if (!KnownElemTy)
+          return true;
+        Uncomplete = isTodoType(Op);
----------------
MrSidims wrote:

... so if the idea to set that the type is TBD, then parameter should be name `Incomplete` (and please accept my apologies for such nitpicking :) )

Also, I don't see `Un/Incomplete` variable to be really used in the code (originally based on the name I though there would be
```
 if (Uncomplete) {
 /* store something and do early exit */
 }
```

but seems like it's added as a function parameter just to silence the warning of the unused return from `isTodoType`, or am I missing something?

https://github.com/llvm/llvm-project/pull/127492