[llvm] [LoopInterchange] Stop performing unprofitable interchange (PR #127473)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 8a0914c24530c98c5ff65bce3710552ce3ebf7d7 0a05312a3084ad2a0d5e8f821d4ca31c22c8fc9f --extensions cpp -- llvm/lib/Transforms/Scalar/LoopInterchange.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Transforms/Scalar/LoopInterchange.cpp b/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
index faa4e22d0d..056b69c4e2 100644
--- a/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
@@ -363,7 +363,8 @@ using CostMapTy = DenseMap<const Loop *, std::pair<unsigned, CacheCostTy>>;
 class LoopInterchangeProfitability {
 public:
   LoopInterchangeProfitability(Loop *Outer, Loop *Inner, ScalarEvolution *SE,
-                               OptimizationRemarkEmitter *ORE, const std::optional<CostMapTy> &CM)
+                               OptimizationRemarkEmitter *ORE,
+                               const std::optional<CostMapTy> &CM)
       : OuterLoop(Outer), InnerLoop(Inner), SE(SE), ORE(ORE), CostMap(CM) {}
 
   /// Check if the loop interchange is profitable.
@@ -549,7 +550,8 @@ struct LoopInterchange {
     }
     LLVM_DEBUG(dbgs() << "Loops are legal to interchange\n");
     LoopInterchangeProfitability LIP(OuterLoop, InnerLoop, SE, ORE, CostMap);
-    if (!LIP.isProfitable(InnerLoop, OuterLoop, InnerLoopId, OuterLoopId, DependencyMatrix)) {
+    if (!LIP.isProfitable(InnerLoop, OuterLoop, InnerLoopId, OuterLoopId,
+                          DependencyMatrix)) {
       LLVM_DEBUG(dbgs() << "Interchanging loops not profitable.\n");
       return false;
     }
@@ -1232,9 +1234,11 @@ std::optional<bool> LoopInterchangeProfitability::isProfitableForVectorization(
 // transitivity might cause some optimization opportunities to be lost, but
 // won't trigger an unprofitable one. Moreover, guaranteeing transitivity is
 // expensive. Therefore, isProfitable only holds the asymmetry.
-bool LoopInterchangeProfitability::isProfitable(
-    const Loop *InnerLoop, const Loop *OuterLoop, unsigned InnerLoopId,
-    unsigned OuterLoopId, CharMatrix &DepMatrix) {
+bool LoopInterchangeProfitability::isProfitable(const Loop *InnerLoop,
+                                                const Loop *OuterLoop,
+                                                unsigned InnerLoopId,
+                                                unsigned OuterLoopId,
+                                                CharMatrix &DepMatrix) {
   // isProfitable() is structured to avoid endless loop interchange.
   // If loop cache analysis could decide the profitability then,
   // profitability check will stop and return the analysis result.

``````````

</details>


https://github.com/llvm/llvm-project/pull/127473