[llvm] 86d8222 - [dsymutil] Avoid repeated hash lookups (NFC) (#127449)

[via llvm-commits]

Author: Kazu Hirata
Date: 2025-02-16T23:44:26-08:00
New Revision: 86d82228a58071a68d7ac450af18eadd641f3477

URL: https://github.com/llvm/llvm-project/commit/86d82228a58071a68d7ac450af18eadd641f3477
DIFF: https://github.com/llvm/llvm-project/commit/86d82228a58071a68d7ac450af18eadd641f3477.diff

LOG: [dsymutil] Avoid repeated hash lookups (NFC) (#127449)

Added: 
    

Modified: 
    llvm/tools/dsymutil/BinaryHolder.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/dsymutil/BinaryHolder.cpp b/llvm/tools/dsymutil/BinaryHolder.cpp
index 7588a33eb46b2..9429afeefa642 100644
--- a/llvm/tools/dsymutil/BinaryHolder.cpp
+++ b/llvm/tools/dsymutil/BinaryHolder.cpp
@@ -288,15 +288,13 @@ void BinaryHolder::eraseObjectEntry(StringRef Filename) {
   if (isArchive(Filename)) {
     StringRef ArchiveFilename = getArchiveAndObjectName(Filename).first;
     std::lock_guard<std::mutex> Lock(ArchiveCacheMutex);
-    ArchiveRefCounter[ArchiveFilename]--;
-    if (ArchiveRefCounter[ArchiveFilename] == 0)
+    if (--ArchiveRefCounter[ArchiveFilename] == 0)
       ArchiveCache.erase(ArchiveFilename);
     return;
   }
 
   std::lock_guard<std::mutex> Lock(ObjectCacheMutex);
-  ObjectRefCounter[Filename]--;
-  if (ObjectRefCounter[Filename] == 0)
+  if (--ObjectRefCounter[Filename] == 0)
     ObjectCache.erase(Filename);
 }