[llvm] [dsymutil] Avoid repeated hash lookups (NFC) (PR #127449)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 16 22:18:37 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-debuginfo
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/127449.diff
1 Files Affected:
- (modified) llvm/tools/dsymutil/BinaryHolder.cpp (+2-4)
``````````diff
diff --git a/llvm/tools/dsymutil/BinaryHolder.cpp b/llvm/tools/dsymutil/BinaryHolder.cpp
index 7588a33eb46b2..9429afeefa642 100644
--- a/llvm/tools/dsymutil/BinaryHolder.cpp
+++ b/llvm/tools/dsymutil/BinaryHolder.cpp
@@ -288,15 +288,13 @@ void BinaryHolder::eraseObjectEntry(StringRef Filename) {
if (isArchive(Filename)) {
StringRef ArchiveFilename = getArchiveAndObjectName(Filename).first;
std::lock_guard<std::mutex> Lock(ArchiveCacheMutex);
- ArchiveRefCounter[ArchiveFilename]--;
- if (ArchiveRefCounter[ArchiveFilename] == 0)
+ if (--ArchiveRefCounter[ArchiveFilename] == 0)
ArchiveCache.erase(ArchiveFilename);
return;
}
std::lock_guard<std::mutex> Lock(ObjectCacheMutex);
- ObjectRefCounter[Filename]--;
- if (ObjectRefCounter[Filename] == 0)
+ if (--ObjectRefCounter[Filename] == 0)
ObjectCache.erase(Filename);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/127449
More information about the llvm-commits
mailing list