https://github.com/artagnon commented: Looks reasonable, although I'm quite unhappy with the existing code: some of the comments can be addressed in follow-ups/pre-commits. https://github.com/llvm/llvm-project/pull/127410