[llvm] [NFC][AMDGPU] Remove an obsolete debug assertion trigger (PR #127357)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 15 16:37:38 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Shilei Tian (shiltian)
<details>
<summary>Changes</summary>
The removed code block was previously used to trigger an assertion, which has
since been fixed. However, its presence could cause inconsistent check lines
between debug (or assertion-enabled) builds and release builds. The fact that no
test updates were needed further confirms that this issue no longer exists.
Fixes SWDEV-515712.
---
Full diff: https://github.com/llvm/llvm-project/pull/127357.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp (-4)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp b/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
index 5805ec658fd61..e177baa1382c7 100644
--- a/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
+++ b/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
@@ -512,10 +512,6 @@ bool PhiLoweringHelper::lowerPhis() {
DT->getNode(RHS.Block)->getDFSNumIn();
});
-#ifndef NDEBUG
- PhiRegisters.insert(DstReg);
-#endif
-
// Phis in a loop that are observed outside the loop receive a simple but
// conservatively correct treatment.
std::vector<MachineBasicBlock *> DomBlocks = {&MBB};
``````````
</details>
https://github.com/llvm/llvm-project/pull/127357
More information about the llvm-commits
mailing list