[llvm] [NFC][AMDGPU] Remove an obsolete debug assertion trigger (PR #127357)

[Shilei Tian via llvm-commits]

https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/127357

The removed code block was previously used to trigger an assertion, which has
since been fixed. However, its presence could cause inconsistent check lines
between debug (or assertion-enabled) builds and release builds. The fact that no
test updates were needed further confirms that this issue no longer exists.

Fixes SWDEV-515712.

>From 1c3debf12b1ceaf54ee2891e4a5262c76c36ef1e Mon Sep 17 00:00:00 2001
From: Shilei Tian <i at tianshilei.me>
Date: Sat, 15 Feb 2025 19:36:29 -0500
Subject: [PATCH] [NFC][AMDGPU] Remove an obsolete debug assertion trigger

The removed code block was previously used to trigger an assertion, which has
since been fixed. However, its presence could cause inconsistent check lines
between debug (or assertion-enabled) builds and release builds. The fact that no
test updates were needed further confirms that this issue no longer exists.

Fixes SWDEV-515712.
---
 llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp b/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
index 5805ec658fd61..e177baa1382c7 100644
--- a/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
+++ b/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
@@ -512,10 +512,6 @@ bool PhiLoweringHelper::lowerPhis() {
              DT->getNode(RHS.Block)->getDFSNumIn();
     });
 
-#ifndef NDEBUG
-    PhiRegisters.insert(DstReg);
-#endif
-
     // Phis in a loop that are observed outside the loop receive a simple but
     // conservatively correct treatment.
     std::vector<MachineBasicBlock *> DomBlocks = {&MBB};