[llvm] ConstRange: exhaustively test makeExactICmpRegion (PR #127058)

Ramkumar Ramachandra via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 15 03:55:31 PST 2025


artagnon wrote:

> Should we remove the assertion here?
> 
> https://github.com/llvm/llvm-project/blob/2db262886f0c06c079e1b2808c4c14c16f8861b5/llvm/lib/IR/ConstantRange.cpp#L166

Good idea.
 
> Do you have a plan to test with samesign in follow-up patches?

As I described on the other patch, samesign produces a disjoint union of two ConstantRanges, so I don't think it makes sense to teach ConstantRange about samesign anymore.

https://github.com/llvm/llvm-project/pull/127058


More information about the llvm-commits mailing list