[llvm] 66465c3 - Revert "Make llvm::telemetry::Manager::preDispatch protected. (#127114)"

[Kazu Hirata via llvm-commits]

Author: Kazu Hirata
Date: 2025-02-14T21:23:33-08:00
New Revision: 66465c3b0ab1b32403ad5a1c3114174d87830f54

URL: https://github.com/llvm/llvm-project/commit/66465c3b0ab1b32403ad5a1c3114174d87830f54
DIFF: https://github.com/llvm/llvm-project/commit/66465c3b0ab1b32403ad5a1c3114174d87830f54.diff

LOG: Revert "Make llvm::telemetry::Manager::preDispatch protected.  (#127114)"

This reverts commit f7a2d70bd91094e7a85f7e189602c826a3eeb6cd.

Multiple buildbot failures have been reported.  See:
https://github.com/llvm/llvm-project/pull/127114

Added: 
    

Modified: 
    llvm/include/llvm/Telemetry/Telemetry.h
    llvm/lib/Telemetry/Telemetry.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Telemetry/Telemetry.h b/llvm/include/llvm/Telemetry/Telemetry.h
index 8efea645ab51c..344a49df5cbf0 100644
--- a/llvm/include/llvm/Telemetry/Telemetry.h
+++ b/llvm/include/llvm/Telemetry/Telemetry.h
@@ -138,6 +138,10 @@ class Manager {
 public:
   virtual ~Manager() = default;
 
+  // Optional callback for subclasses to perform additional tasks before
+  // dispatching to Destinations.
+  virtual Error preDispatch(TelemetryInfo *Entry) = 0;
+
   // Dispatch Telemetry data to the Destination(s).
   // The argument is non-const because the Manager may add or remove
   // data from the entry.
@@ -146,11 +150,6 @@ class Manager {
   // Register a Destination.
   void addDestination(std::unique_ptr<Destination> Destination);
 
-protected:
-  // Optional callback for subclasses to perform additional tasks before
-  // dispatching to Destinations.
-  virtual Error preDispatch(TelemetryInfo *Entry) {}
-
 private:
   std::vector<std::unique_ptr<Destination>> Destinations;
 };

diff  --git a/llvm/lib/Telemetry/Telemetry.cpp b/llvm/lib/Telemetry/Telemetry.cpp
index badb07bff5477..9e13d08334e3b 100644
--- a/llvm/lib/Telemetry/Telemetry.cpp
+++ b/llvm/lib/Telemetry/Telemetry.cpp
@@ -1,16 +1,3 @@
-//===----------------------------------------------------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-///
-/// \file
-/// This file provides the basic framework for Telemetry.
-/// Refer to its documentation at llvm/docs/Telemetry.rst for more details.
-//===---------------------------------------------------------------------===//
-
 #include "llvm/Telemetry/Telemetry.h"
 
 namespace llvm {