[llvm] [CodingStandard] Add a rule about non-member definitions in CPP files (PR #126775)

[Rahul Joshi via llvm-commits]

jurahul wrote:

Sounds good. I’ll update the PR and rework this entire section.

On Fri, Feb 14, 2025 at 4:46 AM Aaron Ballman ***@***.***>
wrote:

> ***@***.**** commented on this pull request.
> ------------------------------
>
> In llvm/docs/CodingStandards.rst
> <https://github.com/llvm/llvm-project/pull/126775#discussion_r1956094441>:
>
> > +Related to this issue, when non-member functions or variables are defined in a
> +`.cpp`` file and need not be referenced outside that file, make them `static`.
>
> Or to belabor on this more, may be this should be the first paragraph,
> saying that things should be as private as possible, and then going into
> how to achieve that via static or anon namespaces. The section can be
> renamed to something like privatize aggressively or keep it as is.
>
> This format would make more sense to me. Basically, "Here's the principle
> we want to follow and why. Here's how to follow that principle." Should we
> also strongly encourage using private and protected access specifiers
> within classes too? Then the section is basically about all the ways in
> which you can restrict access to identifiers. (I don't know if I'm
> scope-creeping too much though.)
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/126775#discussion_r1956094441>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRMUB7HQU2TCRAGAN6ZS2D2PXQTTAVCNFSM6AAAAABW5XAQIOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJXG4YDEOJZG4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/126775