[llvm] [SPIR-V] Add support for inline SPIR-V types (PR #125316)
Vyacheslav Levytskyy via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 14 06:16:21 PST 2025
================
@@ -0,0 +1,43 @@
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
----------------
VyacheslavLevytskyy wrote:
Again, just as an idea, one more, bigger and more close to real-world applications test case may help. Not necessary inside this very patch, maybe in a followup. To explain my reasoning and as an example, I should expect that without wrapping of `SPIRVGlobalRegistry::getOrCreateUnknownType` into `createOpType(...)` (see my comment above) a more length test case would break Machine Verifier rules and we would receive an error under `-verify-machineinstrs` run. Such a longer example could be a target of just passing `spirv-val` and `-verify-machineinstrs` checks, without any tedious pattern matching -- its goal would be to guarantee general correctness of the generated code rather than correspondence to particular requirements to inline SPIR-V types. Again, only as an idea.
https://github.com/llvm/llvm-project/pull/125316
More information about the llvm-commits
mailing list