[llvm] [AArch64][Build Attributes] Remove wrong assertion (PR #127097)

[via llvm-commits]

https://github.com/sivan-shani created https://github.com/llvm/llvm-project/pull/127097

Adding an existing AArch64 Build Attributes value is legal. Asserting this case is wrong, it cause wrong behavior when assertions are enabled.

>From 8a0e962d4680c4d6a3de61b2fbac1fbd3374e81c Mon Sep 17 00:00:00 2001
From: Sivan Shani <sivan.shani at arm.com>
Date: Thu, 13 Feb 2025 17:12:28 +0000
Subject: [PATCH] [AArch64][Build Attributes] Remove wrong assert

Adding an existing AArch64 Build Attributes value is legal.
Asserting this case is wrong, it cause wrong behavior when assertions are enabled.
---
 .../Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
index 1ed4a81a97673..cdad5c7de7853 100644
--- a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
+++ b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
@@ -222,13 +222,9 @@ void AArch64TargetStreamer::emitAttribute(StringRef VendorName, unsigned Tag,
                      "Can not add AArch64 build attribute: An attribute with "
                      "the same tag and a different value already exists");
               return;
-            } else {
-              // Case Item.IntValue == Value, no need to emit twice
-              assert(0 &&
-                     "AArch64 build attribute: An attribute with the same tag "
-                     "and a same value already exists");
-              return;
             }
+            // Case (Item.IntValue == Value) is legal.
+            return;
           }
         }
       }