[llvm] [X86][NFC] Added/Updated Trigonometric functions testcase (PR #127094)
Evgenii Kudriashov via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 13 09:06:13 PST 2025
e-kud wrote:
@RKSimon @arsenm apparently we haven't got any tests for `llvm.{sin,cos}.*` and this revealed some inconsistency:
* for most of opcodes `half` and `fp128` tests are included into `CodeGen/X86/llvm.*.ll`
* for `sin` and `cos` (and other non-trigonometric intrinsics) they are part of `CodeGen/X86/fp16-libcalls.ll` and `CodeGen/X86/fp128-libcalls.ll`
Should we move `half` and `fp128` cases from `CodeGen/X86/llvm.*.ll` to `CodeGen/X86/{fp16,fp128}-libcalls.ll` or vice versa, or just keep it as is? What do you think would be better?
For GlobalISel it would be better to have `half` and `fp128` separately so we can enforce `global-isel=1` for testing
https://github.com/llvm/llvm-project/pull/127094
More information about the llvm-commits
mailing list