[llvm] [DXIL] Add support for root signature flag element in DXContainer (PR #123147)

[Chris B via llvm-commits]

================
@@ -280,11 +278,9 @@ Error DirectX::RootSignature::parse(StringRef Data) {
       support::endian::read<uint32_t, llvm::endianness::little>(Current);
   Current += sizeof(uint32_t);
 
-  Expected<uint32_t> MaybeFlag =
-      dxbc::RootSignatureValidations::validateRootFlag(FValue);
-  if (Error E = MaybeFlag.takeError())
-    return E;
-  Flags = MaybeFlag.get();
+  if (dxbc::RootSignatureValidations::validateRootFlag(FValue))
+    return make_error<GenericBinaryError>("Invalid Root Signature flag");
----------------
llvm-beanz wrote:

Same feedback as above, we can make this a useful error.

https://github.com/llvm/llvm-project/pull/123147