[llvm] 8260528 - [LAA] Also clear CheckingGroups in RuntimePointerChecking::reset.
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 12 12:49:44 PST 2025
Author: Florian Hahn
Date: 2025-02-12T21:49:22+01:00
New Revision: 82605285b8c647f4248bb22f2c9d19945cfcba8c
URL: https://github.com/llvm/llvm-project/commit/82605285b8c647f4248bb22f2c9d19945cfcba8c
DIFF: https://github.com/llvm/llvm-project/commit/82605285b8c647f4248bb22f2c9d19945cfcba8c.diff
LOG: [LAA] Also clear CheckingGroups in RuntimePointerChecking::reset.
This fixes a crash when trying to print access-info in the newly added
test cases.
Added:
llvm/test/Analysis/LoopAccessAnalysis/retry-runtime-checks-after-dependence-analysis.ll
Modified:
llvm/include/llvm/Analysis/LoopAccessAnalysis.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/Analysis/LoopAccessAnalysis.h b/llvm/include/llvm/Analysis/LoopAccessAnalysis.h
index 6fc6ca14d0889..b675c4f875448 100644
--- a/llvm/include/llvm/Analysis/LoopAccessAnalysis.h
+++ b/llvm/include/llvm/Analysis/LoopAccessAnalysis.h
@@ -497,6 +497,7 @@ class RuntimePointerChecking {
Pointers.clear();
Checks.clear();
DiffChecks.clear();
+ CheckingGroups.clear();
}
/// Insert a pointer and calculate the start and end SCEVs.
diff --git a/llvm/test/Analysis/LoopAccessAnalysis/retry-runtime-checks-after-dependence-analysis.ll b/llvm/test/Analysis/LoopAccessAnalysis/retry-runtime-checks-after-dependence-analysis.ll
new file mode 100644
index 0000000000000..e42392df3e93e
--- /dev/null
+++ b/llvm/test/Analysis/LoopAccessAnalysis/retry-runtime-checks-after-dependence-analysis.ll
@@ -0,0 +1,245 @@
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -passes='print<access-info>' -disable-output %s 2>&1 | FileCheck %s
+
+define void @dependency_check_and_runtime_checks_needed_gepb_is_inbounds_iv2_step5(ptr %a, ptr %b, i64 %offset, i64 %n) {
+; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_is_inbounds_iv2_step5'
+; CHECK-NEXT: loop:
+; CHECK-NEXT: Memory dependences are safe with run-time checks
+; CHECK-NEXT: Dependences:
+; CHECK-NEXT: Run-time memory checks:
+; CHECK-NEXT: Check 0:
+; CHECK-NEXT: Comparing group ([[GRP1:0x[0-9a-f]+]]):
+; CHECK-NEXT: %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+; CHECK-NEXT: Against group ([[GRP2:0x[0-9a-f]+]]):
+; CHECK-NEXT: %gep.b = getelementptr inbounds float, ptr %b, i64 %iv2
+; CHECK-NEXT: Check 1:
+; CHECK-NEXT: Comparing group ([[GRP1]]):
+; CHECK-NEXT: %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+; CHECK-NEXT: Against group ([[GRP3:0x[0-9a-f]+]]):
+; CHECK-NEXT: %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+; CHECK-NEXT: Check 2:
+; CHECK-NEXT: Comparing group ([[GRP2]]):
+; CHECK-NEXT: %gep.b = getelementptr inbounds float, ptr %b, i64 %iv2
+; CHECK-NEXT: Against group ([[GRP3]]):
+; CHECK-NEXT: %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+; CHECK-NEXT: Grouped accesses:
+; CHECK-NEXT: Group [[GRP1]]:
+; CHECK-NEXT: (Low: %a High: ((4 * %n) + %a))
+; CHECK-NEXT: Member: {%a,+,4}<nuw><%loop>
+; CHECK-NEXT: Group [[GRP2]]:
+; CHECK-NEXT: (Low: %b High: (-16 + (20 * %n) + %b))
+; CHECK-NEXT: Member: {%b,+,20}<%loop>
+; CHECK-NEXT: Group [[GRP3]]:
+; CHECK-NEXT: (Low: ((4 * %offset) + %a) High: ((4 * %offset) + (4 * %n) + %a))
+; CHECK-NEXT: Member: {((4 * %offset) + %a),+,4}<%loop>
+; CHECK-EMPTY:
+; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
+; CHECK-NEXT: SCEV assumptions:
+; CHECK-EMPTY:
+; CHECK-NEXT: Expressions re-written:
+;
+entry:
+ br label %loop
+
+loop:
+ %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
+ %iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
+ %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+ %l1 = load float, ptr %gep.a.iv, align 4
+ %iv.offset = add i64 %iv, %offset
+ %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+ %l2 = load float, ptr %gep.a.iv.off, align 4
+ %ad = fadd fast float %l1, %l2
+ store float %ad, ptr %gep.a.iv, align 4
+ %gep.b = getelementptr inbounds float, ptr %b, i64 %iv2
+ store float 0.0, ptr %gep.b
+ %iv.next = add nuw nsw i64 %iv, 1
+ %iv2.next = add i64 %iv2, 5
+ %exitcond = icmp eq i64 %iv.next, %n
+ br i1 %exitcond, label %exit, label %loop
+
+exit:
+ ret void
+}
+
+define void @dependency_check_and_runtime_checks_needed_gepb_not_inbounds_iv2_step5(ptr %a, ptr %b, i64 %offset, i64 %n) {
+; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_not_inbounds_iv2_step5'
+; CHECK-NEXT: loop:
+; CHECK-NEXT: Report: cannot check memory dependencies at runtime
+; CHECK-NEXT: Dependences:
+; CHECK-NEXT: Run-time memory checks:
+; CHECK-NEXT: Grouped accesses:
+; CHECK-EMPTY:
+; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
+; CHECK-NEXT: SCEV assumptions:
+; CHECK-EMPTY:
+; CHECK-NEXT: Expressions re-written:
+;
+entry:
+ br label %loop
+
+loop:
+ %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
+ %iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
+ %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+ %l1 = load float, ptr %gep.a.iv, align 4
+ %iv.offset = add i64 %iv, %offset
+ %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+ %l2 = load float, ptr %gep.a.iv.off, align 4
+ %ad = fadd fast float %l1, %l2
+ store float %ad, ptr %gep.a.iv, align 4
+ %gep.b = getelementptr i8, ptr %b, i64 %iv2
+ store float 0.0, ptr %gep.b
+ %iv.next = add nuw nsw i64 %iv, 1
+ %iv2.next = add i64 %iv2, 5
+ %exitcond = icmp eq i64 %iv.next, %n
+ br i1 %exitcond, label %exit, label %loop
+
+exit:
+ ret void
+}
+
+define void @dependency_check_and_runtime_checks_needed_gepb_is_inbounds_iv2_step_not_constant(ptr %a, ptr %b, i64 %offset, i64 %n, i64 %s) {
+; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_is_inbounds_iv2_step_not_constant'
+; CHECK-NEXT: loop:
+; CHECK-NEXT: Report: cannot check memory dependencies at runtime
+; CHECK-NEXT: Dependences:
+; CHECK-NEXT: Run-time memory checks:
+; CHECK-NEXT: Grouped accesses:
+; CHECK-EMPTY:
+; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
+; CHECK-NEXT: SCEV assumptions:
+; CHECK-NEXT: Equal predicate: %s == 1
+; CHECK-EMPTY:
+; CHECK-NEXT: Expressions re-written:
+; CHECK-NEXT: [PSE] %gep.b = getelementptr inbounds i8, ptr %b, i64 %iv2:
+; CHECK-NEXT: {%b,+,%s}<%loop>
+; CHECK-NEXT: --> {%b,+,1}<%loop>
+;
+entry:
+ br label %loop
+
+loop:
+ %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
+ %iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
+ %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+ %l1 = load float, ptr %gep.a.iv, align 4
+ %iv.offset = add i64 %iv, %offset
+ %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+ %l2 = load float, ptr %gep.a.iv.off, align 4
+ %ad = fadd fast float %l1, %l2
+ store float %ad, ptr %gep.a.iv, align 4
+ %gep.b = getelementptr inbounds i8, ptr %b, i64 %iv2
+ store float 0.0, ptr %gep.b
+ %iv.next = add nuw nsw i64 %iv, 1
+ %iv2.next = add i64 %iv2, %s
+ %exitcond = icmp eq i64 %iv.next, %n
+ br i1 %exitcond, label %exit, label %loop
+
+exit:
+ ret void
+}
+
+
+define void @dependency_check_and_runtime_checks_needed_gepb_not_inbounds_iv2_step_not_constant(ptr %a, ptr %b, i64 %offset, i64 %n, i64 %s) {
+; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_not_inbounds_iv2_step_not_constant'
+; CHECK-NEXT: loop:
+; CHECK-NEXT: Report: cannot check memory dependencies at runtime
+; CHECK-NEXT: Dependences:
+; CHECK-NEXT: Run-time memory checks:
+; CHECK-NEXT: Grouped accesses:
+; CHECK-EMPTY:
+; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
+; CHECK-NEXT: SCEV assumptions:
+; CHECK-NEXT: Equal predicate: %s == 1
+; CHECK-EMPTY:
+; CHECK-NEXT: Expressions re-written:
+; CHECK-NEXT: [PSE] %gep.b = getelementptr inbounds i8, ptr %b, i64 %iv2:
+; CHECK-NEXT: {%b,+,%s}<%loop>
+; CHECK-NEXT: --> {%b,+,1}<%loop>
+;
+entry:
+ br label %loop
+
+loop:
+ %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
+ %iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
+ %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+ %l1 = load float, ptr %gep.a.iv, align 4
+ %iv.offset = add i64 %iv, %offset
+ %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+ %l2 = load float, ptr %gep.a.iv.off, align 4
+ %ad = fadd fast float %l1, %l2
+ store float %ad, ptr %gep.a.iv, align 4
+ %gep.b = getelementptr inbounds i8, ptr %b, i64 %iv2
+ store float 0.0, ptr %gep.b
+ %iv.next = add nuw nsw i64 %iv, 1
+ %iv2.next = add i64 %iv2, %s
+ %exitcond = icmp eq i64 %iv.next, %n
+ br i1 %exitcond, label %exit, label %loop
+
+exit:
+ ret void
+}
+
+define void @dependency_check_and_runtime_checks_needed_gepb_may_wrap(ptr %a, ptr %b, i64 %offset, i64 %n) {
+; CHECK-LABEL: 'dependency_check_and_runtime_checks_needed_gepb_may_wrap'
+; CHECK-NEXT: loop:
+; CHECK-NEXT: Memory dependences are safe with run-time checks
+; CHECK-NEXT: Dependences:
+; CHECK-NEXT: Run-time memory checks:
+; CHECK-NEXT: Check 0:
+; CHECK-NEXT: Comparing group ([[GRP4:0x[0-9a-f]+]]):
+; CHECK-NEXT: %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+; CHECK-NEXT: Against group ([[GRP5:0x[0-9a-f]+]]):
+; CHECK-NEXT: %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+; CHECK-NEXT: Check 1:
+; CHECK-NEXT: Comparing group ([[GRP4]]):
+; CHECK-NEXT: %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+; CHECK-NEXT: Against group ([[GRP6:0x[0-9a-f]+]]):
+; CHECK-NEXT: %gep.b = getelementptr float, ptr %b, i64 %iv2
+; CHECK-NEXT: Check 2:
+; CHECK-NEXT: Comparing group ([[GRP5]]):
+; CHECK-NEXT: %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+; CHECK-NEXT: Against group ([[GRP6]]):
+; CHECK-NEXT: %gep.b = getelementptr float, ptr %b, i64 %iv2
+; CHECK-NEXT: Grouped accesses:
+; CHECK-NEXT: Group [[GRP4]]:
+; CHECK-NEXT: (Low: %a High: ((4 * %n) + %a))
+; CHECK-NEXT: Member: {%a,+,4}<nuw><%loop>
+; CHECK-NEXT: Group [[GRP5]]:
+; CHECK-NEXT: (Low: ((4 * %offset) + %a) High: ((4 * %offset) + (4 * %n) + %a))
+; CHECK-NEXT: Member: {((4 * %offset) + %a),+,4}<%loop>
+; CHECK-NEXT: Group [[GRP6]]:
+; CHECK-NEXT: (Low: %b High: (-4 + (8 * %n) + %b))
+; CHECK-NEXT: Member: {%b,+,8}<%loop>
+; CHECK-EMPTY:
+; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
+; CHECK-NEXT: SCEV assumptions:
+; CHECK-NEXT: {%b,+,8}<%loop> Added Flags: <nusw>
+; CHECK-EMPTY:
+; CHECK-NEXT: Expressions re-written:
+;
+entry:
+ br label %loop
+
+loop:
+ %iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
+ %iv2 = phi i64 [ 0, %entry ], [ %iv2.next, %loop ]
+ %gep.a.iv = getelementptr inbounds float, ptr %a, i64 %iv
+ %l1 = load float, ptr %gep.a.iv, align 4
+ %iv.offset = add i64 %iv, %offset
+ %gep.a.iv.off = getelementptr inbounds float, ptr %a, i64 %iv.offset
+ %l2 = load float, ptr %gep.a.iv.off, align 4
+ %ad = fadd fast float %l1, %l2
+ store float %ad, ptr %gep.a.iv, align 4
+ %gep.b = getelementptr float, ptr %b, i64 %iv2
+ store float 0.0, ptr %gep.b
+ %iv.next = add nuw nsw i64 %iv, 1
+ %iv2.next = add i64 %iv2, 2
+ %exitcond = icmp eq i64 %iv.next, %n
+ br i1 %exitcond, label %exit, label %loop
+
+exit:
+ ret void
+}
More information about the llvm-commits
mailing list