[llvm] [Offload] Implement the remaining initial Offload API (PR #122106)

Callum Fare via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 09:58:12 PST 2025


================
@@ -16,8 +16,8 @@ def : Function {
     let details = [];
     let params = [
         Param<"ol_queue_handle_t", "Queue", "handle of the queue", PARAM_IN>,
----------------
callumfare wrote:

Sorry I didn't actually see your last comment, I think everything I said above applies though. 

One other issue I can see is who owns host allocations. If you make an allocation on the host plugin, that's not the same as a host allocation made by one of the other plugins (since memory is managed, pinned, etc).

https://github.com/llvm/llvm-project/pull/122106


More information about the llvm-commits mailing list