[llvm] 085bdb1 - [X86] canonicalizeShuffleWithOp - don't bother trying to move shuffles across binops to fold the load. (#126894)

[via llvm-commits]

Author: Simon Pilgrim
Date: 2025-02-12T12:13:11Z
New Revision: 085bdb1e4c0b584aba84d90bf72997f6476881bc

URL: https://github.com/llvm/llvm-project/commit/085bdb1e4c0b584aba84d90bf72997f6476881bc
DIFF: https://github.com/llvm/llvm-project/commit/085bdb1e4c0b584aba84d90bf72997f6476881bc.diff

LOG: [X86] canonicalizeShuffleWithOp - don't bother trying to move shuffles across binops to fold the load. (#126894)

Its not currently used, but is likely to just introduce additional shuffles, resulting in higher Port5 pressure etc. in future patches.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 134a5617ee768..77c426f214675 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -41579,8 +41579,7 @@ static SDValue canonicalizeShuffleWithOp(SDValue N, SelectionDAG &DAG,
   EVT ShuffleVT = N.getValueType();
   unsigned Opc = N.getOpcode();
 
-  auto IsMergeableWithShuffle = [Opc, &DAG](SDValue Op, bool FoldShuf = true,
-                                            bool FoldLoad = false) {
+  auto IsMergeableWithShuffle = [Opc, &DAG](SDValue Op, bool FoldShuf = true) {
     // AllZeros/AllOnes constants are freely shuffled and will peek through
     // bitcasts. Other constant build vectors do not peek through bitcasts. Only
     // merge with target shuffles if it has one use so shuffle combining is
@@ -41593,7 +41592,6 @@ static SDValue canonicalizeShuffleWithOp(SDValue N, SelectionDAG &DAG,
            (Op.getOpcode() == Opc && Op->hasOneUse()) ||
            (Op.getOpcode() == ISD::INSERT_SUBVECTOR && Op->hasOneUse()) ||
            (FoldShuf && isTargetShuffle(Op.getOpcode()) && Op->hasOneUse()) ||
-           (FoldLoad && isShuffleFoldableLoad(Op)) ||
            DAG.isSplatValue(Op, /*AllowUndefs*/ false);
   };
   auto IsSafeToMoveShuffle = [ShuffleVT](SDValue Op, unsigned BinOp) {
@@ -41629,9 +41627,8 @@ static SDValue canonicalizeShuffleWithOp(SDValue N, SelectionDAG &DAG,
         SDValue Op00 = peekThroughOneUseBitcasts(N0.getOperand(0));
         SDValue Op01 = peekThroughOneUseBitcasts(N0.getOperand(1));
         bool FoldShuf = Opc != X86ISD::VPERMI;
-        bool FoldLoad = Opc != X86ISD::PSHUFB;
-        if (IsMergeableWithShuffle(Op00, FoldShuf, FoldLoad) ||
-            IsMergeableWithShuffle(Op01, FoldShuf, FoldLoad)) {
+        if (IsMergeableWithShuffle(Op00, FoldShuf) ||
+            IsMergeableWithShuffle(Op01, FoldShuf)) {
           SDValue LHS, RHS;
           Op00 = DAG.getBitcast(ShuffleVT, Op00);
           Op01 = DAG.getBitcast(ShuffleVT, Op01);