[llvm] d222488 - [AsmParser] Remove OperandMatchResultTy (#126650)

[via llvm-commits]

Author: Sam Elliott
Date: 2025-02-11T21:59:05-08:00
New Revision: d222488007b294e897fb5c29971d87c3148ae33b

URL: https://github.com/llvm/llvm-project/commit/d222488007b294e897fb5c29971d87c3148ae33b
DIFF: https://github.com/llvm/llvm-project/commit/d222488007b294e897fb5c29971d87c3148ae33b.diff

LOG: [AsmParser] Remove OperandMatchResultTy (#126650)

This has been deprecated since a479be0f39a3301e9ca634d37cf6454b6d3865c6
from September 2023, before LLVM 18. Surely now enough release cycles
have happened that it can be removed upstream.

Added: 
    

Modified: 
    llvm/include/llvm/MC/MCParser/MCTargetAsmParser.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/MC/MCParser/MCTargetAsmParser.h b/llvm/include/llvm/MC/MCParser/MCTargetAsmParser.h
index 4c88448e6a128..443877391072c 100644
--- a/llvm/include/llvm/MC/MCParser/MCTargetAsmParser.h
+++ b/llvm/include/llvm/MC/MCParser/MCTargetAsmParser.h
@@ -122,15 +122,13 @@ struct ParseInstructionInfo {
     : AsmRewrites(rewrites) {}
 };
 
-enum OperandMatchResultTy {
-  MatchOperand_Success,  // operand matched successfully
-  MatchOperand_NoMatch,  // operand did not match
-  MatchOperand_ParseFail // operand matched but had errors
-};
-
 /// Ternary parse status returned by various parse* methods.
 class ParseStatus {
-  enum class StatusTy { Success, Failure, NoMatch } Status;
+  enum class StatusTy {
+    Success, // Parsing Succeeded
+    Failure, // Parsing Failed after consuming some tokens
+    NoMatch, // Parsing Failed without consuming any tokens
+  } Status;
 
 public:
 #if __cplusplus >= 202002L
@@ -152,19 +150,6 @@ class ParseStatus {
   constexpr bool isSuccess() const { return Status == StatusTy::Success; }
   constexpr bool isFailure() const { return Status == StatusTy::Failure; }
   constexpr bool isNoMatch() const { return Status == StatusTy::NoMatch; }
-
-  // Allow implicit conversions to / from OperandMatchResultTy.
-  LLVM_DEPRECATED("Migrate to ParseStatus", "")
-  constexpr ParseStatus(OperandMatchResultTy R)
-      : Status(R == MatchOperand_Success     ? Success
-               : R == MatchOperand_ParseFail ? Failure
-                                             : NoMatch) {}
-  LLVM_DEPRECATED("Migrate to ParseStatus", "")
-  constexpr operator OperandMatchResultTy() const {
-    return isSuccess()   ? MatchOperand_Success
-           : isFailure() ? MatchOperand_ParseFail
-                         : MatchOperand_NoMatch;
-  }
 };
 
 enum class DiagnosticPredicateTy {