[llvm] [Utils] Avoid repeated hash lookups (NFC) (PR #126856)

[Kazu Hirata via llvm-commits]

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126856

None

>From 5cb68102ec0bee2a6323e63812aab1a1df522574 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Tue, 11 Feb 2025 09:13:54 -0800
Subject: [PATCH] [Utils] Avoid repeated hash lookups (NFC)

---
 .../Transforms/Utils/SampleProfileLoaderBaseImpl.h     | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h b/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
index d86630decd3ae..44cb5183fb31d 100644
--- a/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
+++ b/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
@@ -881,19 +881,21 @@ void SampleProfileLoaderBaseImpl<BT>::buildEdges(FunctionT &F) {
 
     // Add predecessors for B1.
     SmallPtrSet<BasicBlockT *, 16> Visited;
-    if (!Predecessors[B1].empty())
+    auto &Preds = Predecessors[B1];
+    if (!Preds.empty())
       llvm_unreachable("Found a stale predecessors list in a basic block.");
     for (auto *B2 : getPredecessors(B1))
       if (Visited.insert(B2).second)
-        Predecessors[B1].push_back(B2);
+        Preds.push_back(B2);
 
     // Add successors for B1.
     Visited.clear();
-    if (!Successors[B1].empty())
+    auto &Succs = Successors[B1];
+    if (!Succs.empty())
       llvm_unreachable("Found a stale successors list in a basic block.");
     for (auto *B2 : getSuccessors(B1))
       if (Visited.insert(B2).second)
-        Successors[B1].push_back(B2);
+        Succs.push_back(B2);
   }
 }