[llvm] [Object] Avoid repeated map lookups (NFC) (PR #126853)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 21:02:28 PST 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126853

None

>From 19656f7350e247e7e7c878955b8dd3dc731aa6c3 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Tue, 11 Feb 2025 09:15:10 -0800
Subject: [PATCH] [Object] Avoid repeated map lookups (NFC)

---
 llvm/lib/Object/GOFFObjectFile.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/llvm/lib/Object/GOFFObjectFile.cpp b/llvm/lib/Object/GOFFObjectFile.cpp
index db1e7e704f62e..7806953aecd29 100644
--- a/llvm/lib/Object/GOFFObjectFile.cpp
+++ b/llvm/lib/Object/GOFFObjectFile.cpp
@@ -564,8 +564,7 @@ section_iterator GOFFObjectFile::section_end() const {
 
 void GOFFObjectFile::moveSymbolNext(DataRefImpl &Symb) const {
   for (uint32_t I = Symb.d.a + 1, E = EsdPtrs.size(); I < E; ++I) {
-    if (EsdPtrs[I]) {
-      const uint8_t *EsdRecord = EsdPtrs[I];
+    if (const uint8_t *EsdRecord = EsdPtrs[I]) {
       GOFF::ESDSymbolType SymbolType;
       ESDRecord::getSymbolType(EsdRecord, SymbolType);
       // Skip EDs - i.e. section symbols.



More information about the llvm-commits mailing list