[llvm] [DependenceAnalysis][NFC] Removing PossiblyLoopIndependent parameter (PR #124615)
MengXuan Cai via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 11 10:05:50 PST 2025
https://github.com/Narutoworld updated https://github.com/llvm/llvm-project/pull/124615
>From 7a0e84bd688d452e952794468e6033942d29d3e9 Mon Sep 17 00:00:00 2001
From: Alireza Torabian <alireza.torabian at huawei.com>
Date: Mon, 27 Jan 2025 11:48:31 -0500
Subject: [PATCH] [DependenceAnalysis] Removing PossiblyLoopIndependent from
depends parameters
Parameter PossiblyLoopIndependent has lost its intended purpose.
This flag is always set to true in all cases when depends() is
called, hence we want to reconsider the utility of this variable
and remove it from the function signature entirely.
---
llvm/include/llvm/Analysis/DDG.h | 2 +-
llvm/include/llvm/Analysis/DependenceAnalysis.h | 6 +-----
llvm/lib/Analysis/DependenceAnalysis.cpp | 6 +++---
llvm/lib/Analysis/DependenceGraphBuilder.cpp | 2 +-
llvm/lib/Analysis/LoopCacheAnalysis.cpp | 2 +-
llvm/lib/Transforms/Scalar/LoopFuse.cpp | 12 ++++++------
llvm/lib/Transforms/Scalar/LoopInterchange.cpp | 2 +-
llvm/lib/Transforms/Utils/CodeMoverUtils.cpp | 2 +-
llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp | 2 +-
9 files changed, 16 insertions(+), 20 deletions(-)
diff --git a/llvm/include/llvm/Analysis/DDG.h b/llvm/include/llvm/Analysis/DDG.h
index be5f746e31a5732..dfd84a9addb9707 100644
--- a/llvm/include/llvm/Analysis/DDG.h
+++ b/llvm/include/llvm/Analysis/DDG.h
@@ -453,7 +453,7 @@ bool DependenceGraphInfo<NodeType>::getDependencies(
for (auto *SrcI : SrcIList)
for (auto *DstI : DstIList)
if (auto Dep =
- const_cast<DependenceInfo *>(&DI)->depends(SrcI, DstI, true))
+ const_cast<DependenceInfo *>(&DI)->depends(SrcI, DstI))
Deps.push_back(std::move(Dep));
return !Deps.empty();
diff --git a/llvm/include/llvm/Analysis/DependenceAnalysis.h b/llvm/include/llvm/Analysis/DependenceAnalysis.h
index f0a09644e0f4b65..426ac757b4b0da0 100644
--- a/llvm/include/llvm/Analysis/DependenceAnalysis.h
+++ b/llvm/include/llvm/Analysis/DependenceAnalysis.h
@@ -303,12 +303,8 @@ namespace llvm {
/// depends - Tests for a dependence between the Src and Dst instructions.
/// Returns NULL if no dependence; otherwise, returns a Dependence (or a
/// FullDependence) with as much information as can be gleaned.
- /// The flag PossiblyLoopIndependent should be set by the caller
- /// if it appears that control flow can reach from Src to Dst
- /// without traversing a loop back edge.
std::unique_ptr<Dependence> depends(Instruction *Src,
- Instruction *Dst,
- bool PossiblyLoopIndependent);
+ Instruction *Dst);
/// getSplitIteration - Give a dependence that's splittable at some
/// particular level, return the iteration that should be used to split
diff --git a/llvm/lib/Analysis/DependenceAnalysis.cpp b/llvm/lib/Analysis/DependenceAnalysis.cpp
index a4a98ea0bae1463..9858381a8b7d017 100644
--- a/llvm/lib/Analysis/DependenceAnalysis.cpp
+++ b/llvm/lib/Analysis/DependenceAnalysis.cpp
@@ -187,7 +187,7 @@ static void dumpExampleDependence(raw_ostream &OS, DependenceInfo *DA,
if (DstI->mayReadOrWriteMemory()) {
OS << "Src:" << *SrcI << " --> Dst:" << *DstI << "\n";
OS << " da analyze - ";
- if (auto D = DA->depends(&*SrcI, &*DstI, true)) {
+ if (auto D = DA->depends(&*SrcI, &*DstI)) {
// Normalize negative direction vectors if required by clients.
if (NormalizeResults && D->normalize(&SE))
OS << "normalized - ";
@@ -3586,8 +3586,8 @@ bool DependenceInfo::invalidate(Function &F, const PreservedAnalyses &PA,
// Care is required to keep the routine below, getSplitIteration(),
// up to date with respect to this routine.
std::unique_ptr<Dependence>
-DependenceInfo::depends(Instruction *Src, Instruction *Dst,
- bool PossiblyLoopIndependent) {
+DependenceInfo::depends(Instruction *Src, Instruction *Dst) {
+ bool PossiblyLoopIndependent = true;
if (Src == Dst)
PossiblyLoopIndependent = false;
diff --git a/llvm/lib/Analysis/DependenceGraphBuilder.cpp b/llvm/lib/Analysis/DependenceGraphBuilder.cpp
index 7ee2adf49ebb410..80a17613ddad2a1 100644
--- a/llvm/lib/Analysis/DependenceGraphBuilder.cpp
+++ b/llvm/lib/Analysis/DependenceGraphBuilder.cpp
@@ -297,7 +297,7 @@ void AbstractDependenceGraphBuilder<G>::createMemoryDependencyEdges() {
bool BackwardEdgeCreated = false;
for (Instruction *ISrc : SrcIList) {
for (Instruction *IDst : DstIList) {
- auto D = DI.depends(ISrc, IDst, true);
+ auto D = DI.depends(ISrc, IDst);
if (!D)
continue;
diff --git a/llvm/lib/Analysis/LoopCacheAnalysis.cpp b/llvm/lib/Analysis/LoopCacheAnalysis.cpp
index 2897b922f61e48a..050c32707596a7f 100644
--- a/llvm/lib/Analysis/LoopCacheAnalysis.cpp
+++ b/llvm/lib/Analysis/LoopCacheAnalysis.cpp
@@ -224,7 +224,7 @@ IndexedReference::hasTemporalReuse(const IndexedReference &Other,
}
std::unique_ptr<Dependence> D =
- DI.depends(&StoreOrLoadInst, &Other.StoreOrLoadInst, true);
+ DI.depends(&StoreOrLoadInst, &Other.StoreOrLoadInst);
if (D == nullptr) {
LLVM_DEBUG(dbgs().indent(2) << "No temporal reuse: no dependence\n");
diff --git a/llvm/lib/Transforms/Scalar/LoopFuse.cpp b/llvm/lib/Transforms/Scalar/LoopFuse.cpp
index 46b0783004fcdba..eaf89b23c26f760 100644
--- a/llvm/lib/Transforms/Scalar/LoopFuse.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopFuse.cpp
@@ -1099,7 +1099,7 @@ struct LoopFuser {
LLVM_DEBUG(dbgs() << "Checking if this mem inst can be hoisted.\n");
for (Instruction *NotHoistedInst : NotHoisting) {
- if (auto D = DI.depends(&I, NotHoistedInst, true)) {
+ if (auto D = DI.depends(&I, NotHoistedInst)) {
// Dependency is not read-before-write, write-before-read or
// write-before-write
if (D->isFlow() || D->isAnti() || D->isOutput()) {
@@ -1111,7 +1111,7 @@ struct LoopFuser {
}
for (Instruction *ReadInst : FC0.MemReads) {
- if (auto D = DI.depends(ReadInst, &I, true)) {
+ if (auto D = DI.depends(ReadInst, &I)) {
// Dependency is not read-before-write
if (D->isAnti()) {
LLVM_DEBUG(dbgs() << "Inst depends on a read instruction in FC0.\n");
@@ -1121,7 +1121,7 @@ struct LoopFuser {
}
for (Instruction *WriteInst : FC0.MemWrites) {
- if (auto D = DI.depends(WriteInst, &I, true)) {
+ if (auto D = DI.depends(WriteInst, &I)) {
// Dependency is not write-before-read or write-before-write
if (D->isFlow() || D->isOutput()) {
LLVM_DEBUG(dbgs() << "Inst depends on a write instruction in FC0.\n");
@@ -1153,7 +1153,7 @@ struct LoopFuser {
return true;
for (Instruction *ReadInst : FC1.MemReads) {
- if (auto D = DI.depends(&I, ReadInst, true)) {
+ if (auto D = DI.depends(&I, ReadInst)) {
// Dependency is not write-before-read
if (D->isFlow()) {
LLVM_DEBUG(dbgs() << "Inst depends on a read instruction in FC1.\n");
@@ -1163,7 +1163,7 @@ struct LoopFuser {
}
for (Instruction *WriteInst : FC1.MemWrites) {
- if (auto D = DI.depends(&I, WriteInst, true)) {
+ if (auto D = DI.depends(&I, WriteInst)) {
// Dependency is not write-before-write or read-before-write
if (D->isOutput() || D->isAnti()) {
LLVM_DEBUG(dbgs() << "Inst depends on a write instruction in FC1.\n");
@@ -1335,7 +1335,7 @@ struct LoopFuser {
case FUSION_DEPENDENCE_ANALYSIS_SCEV:
return accessDiffIsPositive(*FC0.L, *FC1.L, I0, I1, AnyDep);
case FUSION_DEPENDENCE_ANALYSIS_DA: {
- auto DepResult = DI.depends(&I0, &I1, true);
+ auto DepResult = DI.depends(&I0, &I1);
if (!DepResult)
return true;
#ifndef NDEBUG
diff --git a/llvm/lib/Transforms/Scalar/LoopInterchange.cpp b/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
index 38fc682698c53eb..aac75b8962eb992 100644
--- a/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
@@ -146,7 +146,7 @@ static bool populateDependencyMatrix(CharMatrix &DepMatrix, unsigned Level,
if (isa<LoadInst>(Src) && isa<LoadInst>(Dst))
continue;
// Track Output, Flow, and Anti dependencies.
- if (auto D = DI->depends(Src, Dst, true)) {
+ if (auto D = DI->depends(Src, Dst)) {
assert(D->isOrdered() && "Expected an output, flow or anti dep.");
// If the direction vector is negative, normalize it to
// make it non-negative.
diff --git a/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp b/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
index f34e9c5818dd67f..7bbb451782dda1e 100644
--- a/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
+++ b/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
@@ -398,7 +398,7 @@ bool llvm::isSafeToMoveBefore(Instruction &I, Instruction &InsertPoint,
// Check if I has any output/flow/anti dependences with instructions from \p
// StartInst to \p EndInst.
if (llvm::any_of(InstsToCheck, [&DI, &I](Instruction *CurInst) {
- auto DepResult = DI->depends(&I, CurInst, true);
+ auto DepResult = DI->depends(&I, CurInst);
if (DepResult && (DepResult->isOutput() || DepResult->isFlow() ||
DepResult->isAnti()))
return true;
diff --git a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
index 49209e33f2d1dd0..d9ca38eed758881 100644
--- a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
@@ -708,7 +708,7 @@ static bool checkDependency(Instruction *Src, Instruction *Dst,
// (0,0,>=,*,*)
// Now, the dependency is not necessarily non-negative anymore, i.e.
// unroll-and-jam may violate correctness.
- std::unique_ptr<Dependence> D = DI.depends(Src, Dst, true);
+ std::unique_ptr<Dependence> D = DI.depends(Src, Dst);
if (!D)
return true;
assert(D->isOrdered() && "Expected an output, flow or anti dep.");
More information about the llvm-commits
mailing list