[compiler-rt] [compiler-rt][rtsan] pthread_detach/pthread_kill interception. (PR #126765)

[David CARLIER via llvm-commits]

https://github.com/devnexen created https://github.com/llvm/llvm-project/pull/126765

None

>From 7aa4b0b24ef8ea1cc01fefc4781a56f8655e86f9 Mon Sep 17 00:00:00 2001
From: David Carlier <devnexen at gmail.com>
Date: Tue, 11 Feb 2025 17:03:21 +0000
Subject: [PATCH] [compiler-rt][rtsan] pthread_detach/pthread_kill
 interception.

---
 .../lib/rtsan/rtsan_interceptors_posix.cpp    | 12 ++++++++++
 .../tests/rtsan_test_interceptors_posix.cpp   | 22 +++++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp b/compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
index 410da0748b43348..af074d119e86a32 100644
--- a/compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
+++ b/compiler-rt/lib/rtsan/rtsan_interceptors_posix.cpp
@@ -749,6 +749,16 @@ INTERCEPTOR(int, pthread_rwlock_wrlock, pthread_rwlock_t *lock) {
   return REAL(pthread_rwlock_wrlock)(lock);
 }
 
+INTERCEPTOR(int, pthread_detach, pthread_t thread) {
+  __rtsan_notify_intercepted_call("pthread_detach");
+  return REAL(pthread_detach)(thread);
+}
+
+INTERCEPTOR(int, pthread_kill, pthread_t thread, int signal) {
+  __rtsan_notify_intercepted_call("pthread_kill");
+  return REAL(pthread_kill)(thread, signal);
+}
+
 // Sleeping
 
 INTERCEPTOR(unsigned int, sleep, unsigned int s) {
@@ -1498,6 +1508,8 @@ void __rtsan::InitializeInterceptors() {
   INTERCEPT_FUNCTION(pthread_rwlock_rdlock);
   INTERCEPT_FUNCTION(pthread_rwlock_unlock);
   INTERCEPT_FUNCTION(pthread_rwlock_wrlock);
+  INTERCEPT_FUNCTION(pthread_detach);
+  INTERCEPT_FUNCTION(pthread_kill);
 
   INTERCEPT_FUNCTION(sleep);
   INTERCEPT_FUNCTION(usleep);
diff --git a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
index 98d27caae94b81e..994aeff6a1c8c6a 100644
--- a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
+++ b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors_posix.cpp
@@ -1148,6 +1148,28 @@ TEST(TestRtsanInterceptors, PthreadCondWaitDiesWhenRealtime) {
   pthread_mutex_destroy(&mutex);
 }
 
+TEST(TestRtsanInterceptors, PthreadDetachDiesWhenRealtime) {
+  pthread_t thread{};
+  ASSERT_EQ(0,
+            pthread_create(&thread, nullptr, &FakeThreadEntryPoint, nullptr));
+
+  auto Func = [&thread]() { pthread_detach(thread); };
+
+  ExpectRealtimeDeath(Func, "pthread_detach");
+  ExpectNonRealtimeSurvival(Func);
+}
+
+TEST(TestRtsanInterceptors, PthreadKillDiesWhenRealtime) {
+  pthread_t thread{};
+  ASSERT_EQ(0,
+            pthread_create(&thread, nullptr, &FakeThreadEntryPoint, nullptr));
+
+  auto Func = [&thread]() { pthread_kill(thread, -1); };
+
+  ExpectRealtimeDeath(Func, "pthread_kill");
+  ExpectNonRealtimeSurvival(Func);
+}
+
 class PthreadRwlockTest : public ::testing::Test {
 protected:
   void SetUp() override {