[llvm] [llvm] Support multiple save/restore points in mir (PR #119357)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff ad152f4bcfe465b57562fa003b93f44e1a3b2287 37c305dc0ed45768a3bb97446c106473d388f078 --extensions h,cpp -- llvm/include/llvm/CodeGen/MIRYamlMapping.h llvm/lib/CodeGen/MIRParser/MIRParser.cpp llvm/lib/CodeGen/MIRPrinter.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/CodeGen/MIRYamlMapping.h b/llvm/include/llvm/CodeGen/MIRYamlMapping.h
index d8d1356d15..6f7a1f1d65 100644
--- a/llvm/include/llvm/CodeGen/MIRYamlMapping.h
+++ b/llvm/include/llvm/CodeGen/MIRYamlMapping.h
@@ -634,10 +634,13 @@ namespace yaml {
 struct SaveRestorePointEntry {
   StringValue Point;
 
-  bool operator==(const SaveRestorePointEntry &Other) const { return Point == Other.Point; }
+  bool operator==(const SaveRestorePointEntry &Other) const {
+    return Point == Other.Point;
+  }
 };
 
-using SaveRestorePoints = std::variant<std::vector<SaveRestorePointEntry>, StringValue>;
+using SaveRestorePoints =
+    std::variant<std::vector<SaveRestorePointEntry>, StringValue>;
 
 template <> struct PolymorphicTraits<SaveRestorePoints> {
 
@@ -649,11 +652,14 @@ template <> struct PolymorphicTraits<SaveRestorePoints> {
     llvm_unreachable("Unknown map value kind in SaveRestorePoints");
   }
 
-  static SaveRestorePointEntry& getAsMap(SaveRestorePoints &SRPoints) { llvm_unreachable("111"); }
+  static SaveRestorePointEntry &getAsMap(SaveRestorePoints &SRPoints) {
+    llvm_unreachable("111");
+  }
 
-  static std::vector<SaveRestorePointEntry> &getAsSequence(SaveRestorePoints &SRPoints) {
+  static std::vector<SaveRestorePointEntry> &
+  getAsSequence(SaveRestorePoints &SRPoints) {
     if (!std::holds_alternative<std::vector<SaveRestorePointEntry>>(SRPoints))
-      SRPoints = std::vector<SaveRestorePointEntry>(); 
+      SRPoints = std::vector<SaveRestorePointEntry>();
 
     return std::get<std::vector<SaveRestorePointEntry>>(SRPoints);
   }
@@ -661,9 +667,9 @@ template <> struct PolymorphicTraits<SaveRestorePoints> {
   static StringValue &getAsScalar(SaveRestorePoints &SRPoints) {
     if (!std::holds_alternative<StringValue>(SRPoints))
       SRPoints = StringValue();
-    
+
     return std::get<StringValue>(SRPoints);
-   }
+  }
 };
 
 template <> struct MappingTraits<SaveRestorePointEntry> {
@@ -688,7 +694,6 @@ LLVM_YAML_IS_SEQUENCE_VECTOR(llvm::yaml::SaveRestorePointEntry)
 namespace llvm {
 namespace yaml {
 
-
 /// Serializable representation of MachineFrameInfo.
 ///
 /// Doesn't serialize attributes like 'StackAlignment', 'IsStackRealignable' and
@@ -773,10 +778,12 @@ template <> struct MappingTraits<MachineFrameInfo> {
     YamlIO.mapOptional("localFrameSize", MFI.LocalFrameSize, (unsigned)0);
     YamlIO.mapOptional(
         "savePoint", MFI.SavePoints,
-        SaveRestorePoints(StringValue())); // Don't print it out when it's empty.
+        SaveRestorePoints(
+            StringValue())); // Don't print it out when it's empty.
     YamlIO.mapOptional(
         "restorePoint", MFI.RestorePoints,
-        SaveRestorePoints(StringValue())); // Don't print it out when it's empty.
+        SaveRestorePoints(
+            StringValue())); // Don't print it out when it's empty.
   }
 };
 
diff --git a/llvm/lib/CodeGen/MIRParser/MIRParser.cpp b/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
index 23d93f18f8..e7f7091352 100644
--- a/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
+++ b/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
@@ -1076,8 +1076,10 @@ bool MIRParserImpl::initializeSaveRestorePoints(
     PerFunctionMIParsingState &PFS, const yaml::SaveRestorePoints &YamlSRP,
     bool IsSavePoints) {
   MachineBasicBlock *MBB = nullptr;
-  if (std::holds_alternative<std::vector<yaml::SaveRestorePointEntry>>(YamlSRP)) {
-    const auto &VectorRepr = std::get<std::vector<yaml::SaveRestorePointEntry>>(YamlSRP);
+  if (std::holds_alternative<std::vector<yaml::SaveRestorePointEntry>>(
+          YamlSRP)) {
+    const auto &VectorRepr =
+        std::get<std::vector<yaml::SaveRestorePointEntry>>(YamlSRP);
     if (VectorRepr.empty())
       return false;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/119357