[llvm] [llvm-objdump][ELF]Fix crash when reading strings from .dynstr(#86612) (PR #125679)

[James Henderson via llvm-commits]

================
@@ -235,6 +252,12 @@ template <class ELFT> void ELFDumper<ELFT>::printDynamicSection() {
       Expected<StringRef> StrTabOrErr = getDynamicStrTab(Elf);
       if (StrTabOrErr) {
         const char *Data = StrTabOrErr->data();
+        if (Dyn.getVal() >= StringTableSize) {
+          reportWarning("invalid string table offset", Obj.getFileName());
----------------
jh7370 wrote:

Normally, we like newer warnings to include additional context about what was invalid. In this case, it's debatable about whether it's needed, because the value is printed immediately afterwards. However, the message doesn't say anything about the string table size and therefore what a valid offset would actually be.

https://github.com/llvm/llvm-project/pull/125679