[llvm] [RISCV][Disassemble] Ensure the comment stream of the disassembler is set. (PR #125962)

Francesco Petrogalli via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 15:46:36 PST 2025


fpetrogalli wrote:

> > Maybe we just need to set the comment stream in HexagonDisassembler::getInstruction?
> 
> [...] This is fine for something that is OK to die on a fatal error, but the debugger should never die on bad input. Just throw an error, and let the user continue.

Is this the case? I don't think there is anything wrong with the input being debugged. I would consider this a bug of the debugger (assuming of course we decide to keep https://github.com/llvm/llvm-project/commit/1ea5ce6335c7c0e040f70de16f1080546d242b69).


https://github.com/llvm/llvm-project/pull/125962


More information about the llvm-commits mailing list