[llvm] [AArch64][Build Attributes] Remove assertion (PR #126530)

[via llvm-commits]

https://github.com/sivan-shani updated https://github.com/llvm/llvm-project/pull/126530

>From e49d7e96c9f7aef9ed1190d8a6303db3f6093c75 Mon Sep 17 00:00:00 2001
From: Sivan Shani <sivan.shani at arm.com>
Date: Mon, 10 Feb 2025 15:04:50 +0000
Subject: [PATCH] [AArch64][Build Attributes] Remove assertion

When adding build attributes from assembly, an existing value should not
trigger an assertion. This case is valid, and behavior should remain
consistent between builds with and without assertions.
---
 .../Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
index 1ed4a81a9767390..d4081e606448b4b 100644
--- a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
+++ b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
@@ -222,13 +222,9 @@ void AArch64TargetStreamer::emitAttribute(StringRef VendorName, unsigned Tag,
                      "Can not add AArch64 build attribute: An attribute with "
                      "the same tag and a different value already exists");
               return;
-            } else {
-              // Case Item.IntValue == Value, no need to emit twice
-              assert(0 &&
-                     "AArch64 build attribute: An attribute with the same tag "
-                     "and a same value already exists");
-              return;
             }
+            // Case Item.IntValue == Value, no need to emit twice
+            return;
           }
         }
       }