[lld] [ELF] --package-metadata: support %[0-9a-fA-F][0-9a-fA-F] (PR #126396)

[Peter Smith via llvm-commits]

https://github.com/smithp35 approved this pull request.

Looks good to me.

I thought it might be good to say that HTML named-characters are not supported in the help/man-page (https://sourceware.org/binutils/docs/ld/Options.html#index-_002d_002dpackage_002dmetadata_003dJSON) . But I've not got a strong opinion on that as the error message is clear on what is supported.

I agree that this would be better off passed in an object file, or even via a text file containing the raw JSON. I guess this would have meant too much faffing with one or more build-systems rather than just adding to the linker flags. However it looks like that if we want distros to be able to use LLD, we'll need to support it ... grumble.

https://github.com/llvm/llvm-project/pull/126396