[llvm] [XCOFF][llvm-readobj] Print symbol value kind when dumping symbols (PR #125861)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 10 00:41:34 PST 2025


================
@@ -692,22 +692,26 @@ static StringRef GetSymbolValueName(XCOFF::StorageClass SC) {
   case XCOFF::C_BLOCK:
     return "Value (RelocatableAddress)";
   case XCOFF::C_FILE:
+  case XCOFF::C_BSTAT:
     return "Value (SymbolTableIndex)";
   case XCOFF::C_DWARF:
     return "Value (OffsetInDWARF)";
   case XCOFF::C_FUN:
   case XCOFF::C_STSYM:
+    return "Value (OffsetInCSect)";
   case XCOFF::C_BINCL:
   case XCOFF::C_EINCL:
----------------
jh7370 wrote:

As this is quite a complex set of logic (lots of folded-together `case` statements), I think it makes sense to get 100% coverage on the whole `switch`.

https://github.com/llvm/llvm-project/pull/125861


More information about the llvm-commits mailing list