[llvm] 95922d8 - [dsymutil] Avoid repeated hash lookups (NFC) (#126190) (#126346)

[via llvm-commits]

Author: Kazu Hirata
Date: 2025-02-08T00:49:42-08:00
New Revision: 95922d83341f3476bdc2eccd524a02d9a4ab80da

URL: https://github.com/llvm/llvm-project/commit/95922d83341f3476bdc2eccd524a02d9a4ab80da
DIFF: https://github.com/llvm/llvm-project/commit/95922d83341f3476bdc2eccd524a02d9a4ab80da.diff

LOG: [dsymutil] Avoid repeated hash lookups (NFC) (#126190) (#126346)

Added: 
    

Modified: 
    llvm/tools/dsymutil/BinaryHolder.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/dsymutil/BinaryHolder.cpp b/llvm/tools/dsymutil/BinaryHolder.cpp
index 5daaa6755b2957f..7588a33eb46b22a 100644
--- a/llvm/tools/dsymutil/BinaryHolder.cpp
+++ b/llvm/tools/dsymutil/BinaryHolder.cpp
@@ -176,8 +176,8 @@ BinaryHolder::ArchiveEntry::getObjectEntry(StringRef Filename,
 
   // Try the cache first.
   std::lock_guard<std::mutex> Lock(MemberCacheMutex);
-  if (MemberCache.count(Key))
-    return *MemberCache[Key];
+  if (auto It = MemberCache.find(Key); It != MemberCache.end())
+    return *It->second;
 
   // Create a new ObjectEntry, but don't add it to the cache yet. Loading of
   // the archive members might fail and we don't want to lock the whole archive
@@ -228,8 +228,7 @@ BinaryHolder::ArchiveEntry::getObjectEntry(StringRef Filename,
   if (OE->Objects.empty())
     return errorCodeToError(errc::no_such_file_or_directory);
 
-  MemberCache[Key] = std::move(OE);
-  return *MemberCache[Key];
+  return *(MemberCache[Key] = std::move(OE));
 }
 
 Expected<const BinaryHolder::ObjectEntry &>