[llvm] fb1216e - [NFC][GlobalISel] Minor cleanup in LegalityQuery constructors (#126285)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 7 13:07:22 PST 2025
Author: Rahul Joshi
Date: 2025-02-07T13:07:18-08:00
New Revision: fb1216e82979511a3dfc931e693b575c225c5224
URL: https://github.com/llvm/llvm-project/commit/fb1216e82979511a3dfc931e693b575c225c5224
DIFF: https://github.com/llvm/llvm-project/commit/fb1216e82979511a3dfc931e693b575c225c5224.diff
LOG: [NFC][GlobalISel] Minor cleanup in LegalityQuery constructors (#126285)
- Remove a redundant LegalityQuery constructor by using a default value
for `MMODescrs` and remove const for ArrayRef arguments.
- Use a delegating constructor for `MemDesc` constructor that takes
`MachineMemOperand`.
Added:
Modified:
llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h b/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
index 5d7e03bbaeb7dc2..9472aa196f9b4f8 100644
--- a/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
+++ b/llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
@@ -119,20 +119,17 @@ struct LegalityQuery {
MemDesc(LLT MemoryTy, uint64_t AlignInBits, AtomicOrdering Ordering)
: MemoryTy(MemoryTy), AlignInBits(AlignInBits), Ordering(Ordering) {}
MemDesc(const MachineMemOperand &MMO)
- : MemoryTy(MMO.getMemoryType()),
- AlignInBits(MMO.getAlign().value() * 8),
- Ordering(MMO.getSuccessOrdering()) {}
+ : MemDesc(MMO.getMemoryType(), MMO.getAlign().value() * 8,
+ MMO.getSuccessOrdering()) {}
};
/// Operations which require memory can use this to place requirements on the
/// memory type for each MMO.
ArrayRef<MemDesc> MMODescrs;
- constexpr LegalityQuery(unsigned Opcode, const ArrayRef<LLT> Types,
- const ArrayRef<MemDesc> MMODescrs)
+ constexpr LegalityQuery(unsigned Opcode, ArrayRef<LLT> Types,
+ ArrayRef<MemDesc> MMODescrs = {})
: Opcode(Opcode), Types(Types), MMODescrs(MMODescrs) {}
- constexpr LegalityQuery(unsigned Opcode, const ArrayRef<LLT> Types)
- : LegalityQuery(Opcode, Types, {}) {}
raw_ostream &print(raw_ostream &OS) const;
};
More information about the llvm-commits
mailing list