https://github.com/preames approved this pull request. LGTM w/comments addressed. Though, I'd encourage you to wait on review from @topperc . He's better at spotting subtle problems in this type of thing than I am. https://github.com/llvm/llvm-project/pull/125026