[llvm] [LoopVectorizer][AArch64] Add support for partial reduce subtraction (PR #123636)

[Nicholas Guy via llvm-commits]

================
@@ -8898,8 +8898,24 @@ VPRecipeBuilder::tryToCreatePartialReduction(Instruction *Reduction,
       isa<VPPartialReductionRecipe>(BinOpRecipe))
     std::swap(BinOp, Accumulator);
 
-  return new VPPartialReductionRecipe(Reduction->getOpcode(), BinOp,
-                                      Accumulator, Reduction);
+  unsigned Opcode = Reduction->getOpcode();
+  if (Opcode == Instruction::Sub) {
+    VPBasicBlock *ParentBlock = Builder.getInsertBlock();
+    // TODO Is this ever possible in normal operation, would this check be
+    // better off as an assert (if checked at all)?
+    if (!ParentBlock)
+      return nullptr;
+
+    auto *const Zero = ConstantInt::get(Reduction->getType(), 0);
+    SmallVector<VPValue *, 2> Ops;
+    Ops.push_back(Plan.getOrAddLiveIn(Zero));
+    Ops.push_back(cast<VPWidenRecipe>(BinOp->getDefiningRecipe()));
----------------
NickGuy-Arm wrote:

I was initially using the recipe, and after a few iterations got rid of the direct recipe usage. This stuck around as I didn't register at the time that `BinOp` in this context is the same as the recipe. Will be fixed in the next commit

https://github.com/llvm/llvm-project/pull/123636