[llvm] ValueTracking: modernize isKnownInversion (NFC) (PR #126234)
Ramkumar Ramachandra via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 7 04:04:46 PST 2025
https://github.com/artagnon updated https://github.com/llvm/llvm-project/pull/126234
>From d6978c0b7b7abc632e58c7eefbdfb87d191e09af Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <ramkumar.ramachandra at codasip.com>
Date: Fri, 7 Feb 2025 11:47:10 +0000
Subject: [PATCH] ValueTracking: modernize isKnownInversion (NFC)
---
llvm/lib/Analysis/ValueTracking.cpp | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index 6eba6c0f08c3f40..8a9ad55366ee703 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -8599,7 +8599,7 @@ bool llvm::isKnownInversion(const Value *X, const Value *Y) {
return false;
// They must both have samesign flag or not.
- if (cast<ICmpInst>(X)->hasSameSign() != cast<ICmpInst>(Y)->hasSameSign())
+ if (Pred1.hasSameSign() != Pred2.hasSameSign())
return false;
if (B == C)
@@ -8611,8 +8611,7 @@ bool llvm::isKnownInversion(const Value *X, const Value *Y) {
return false;
// Sign bits of two RHSCs should match.
- if (cast<ICmpInst>(X)->hasSameSign() &&
- RHSC1->isNonNegative() != RHSC2->isNonNegative())
+ if (Pred1.hasSameSign() && RHSC1->isNonNegative() != RHSC2->isNonNegative())
return false;
const auto CR1 = ConstantRange::makeExactICmpRegion(Pred1, *RHSC1);
More information about the llvm-commits
mailing list