[llvm] [DXIL] Adding support to RootSignatureFlags in obj2yaml (PR #122396)
Chris B via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 6 20:06:18 PST 2025
================
@@ -228,6 +242,53 @@ void DXContainer::PartIterator::updateIteratorImpl(const uint32_t Offset) {
IteratorState.Offset = Offset;
}
+Error DirectX::RootSignature::parse(StringRef Data) {
+ const char *Current = Data.begin();
+
+ // Root Signature headers expects 6 integers to be present.
+ if (Data.size() < 6 * sizeof(uint32_t)) {
+ return parseFailed("Invalid data. Too small.");
+ }
----------------
llvm-beanz wrote:
nit: https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
```suggestion
if (Data.size() < 6 * sizeof(uint32_t))
return parseFailed("Invalid data. Too small.");
```
https://github.com/llvm/llvm-project/pull/122396
More information about the llvm-commits
mailing list