[llvm] [RISCV] Prefer (select (x < 0), y, z) -> x >> (XLEN - 1) & (y - z) + z even with Zicond. (PR #125772)

Thu Feb 6 09:53:53 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/12202

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
  Passed           : 45376 (98.14%)
  Expectedly Failed:    28 (0.06%)
[1370/1372] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
[1371/1372] Running the LLVM regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/wasm-ld
-- Testing: 58019 tests, 60 workers --
Testing:  0.. 10.. 20.. 30
FAIL: LLVM :: CodeGen/RISCV/select-const.ll (20134 of 58019)
******************** TEST 'LLVM :: CodeGen/RISCV/select-const.ll' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -target-abi=ilp32 -verify-machineinstrs < /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll    | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -target-abi=ilp32 -verify-machineinstrs
RUN: at line 4: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -mattr=+f -target-abi=ilp32 -verify-machineinstrs < /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll    | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32IF /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -mattr=+f -target-abi=ilp32 -verify-machineinstrs
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32IF /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
RUN: at line 6: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -mattr=+zicond -target-abi=ilp32 -verify-machineinstrs < /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll    | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32ZICOND /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32ZICOND /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -mattr=+zicond -target-abi=ilp32 -verify-machineinstrs
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll:464:20: error: RV32ZICOND-NEXT: expected string not found in input
; RV32ZICOND-NEXT: slti a0, a0, 0
                   ^
<stdin>:237:9: note: scanning from here
# %bb.0:
        ^
<stdin>:238:2: note: possible intended match here
 srai a0, a0, 31
 ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll:513:20: error: RV32ZICOND-NEXT: expected string not found in input
; RV32ZICOND-NEXT: slti a0, a0, 0
                   ^
<stdin>:251:9: note: scanning from here
# %bb.0:
        ^
<stdin>:252:2: note: possible intended match here
 srai a0, a0, 31
 ^

Input file: <stdin>
Check file: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll

-dump-input=help explains the following input dump.

Step 7 (check) failure: check (failure)
...
  Passed           : 45376 (98.14%)
  Expectedly Failed:    28 (0.06%)
[1370/1372] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
[1371/1372] Running the LLVM regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/wasm-ld
-- Testing: 58019 tests, 60 workers --
Testing:  0.. 10.. 20.. 30
FAIL: LLVM :: CodeGen/RISCV/select-const.ll (20134 of 58019)
******************** TEST 'LLVM :: CodeGen/RISCV/select-const.ll' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -target-abi=ilp32 -verify-machineinstrs < /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll    | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -target-abi=ilp32 -verify-machineinstrs
RUN: at line 4: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -mattr=+f -target-abi=ilp32 -verify-machineinstrs < /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll    | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32IF /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -mattr=+f -target-abi=ilp32 -verify-machineinstrs
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32IF /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
RUN: at line 6: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -mattr=+zicond -target-abi=ilp32 -verify-machineinstrs < /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll    | /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32ZICOND /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/FileCheck -check-prefixes=RV32,RV32ZICOND /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-bq7s642q/bin/llc -mtriple=riscv32 -mattr=+zicond -target-abi=ilp32 -verify-machineinstrs
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll:464:20: error: RV32ZICOND-NEXT: expected string not found in input
; RV32ZICOND-NEXT: slti a0, a0, 0
                   ^
<stdin>:237:9: note: scanning from here
# %bb.0:
        ^
<stdin>:238:2: note: possible intended match here
 srai a0, a0, 31
 ^
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll:513:20: error: RV32ZICOND-NEXT: expected string not found in input
; RV32ZICOND-NEXT: slti a0, a0, 0
                   ^
<stdin>:251:9: note: scanning from here
# %bb.0:
        ^
<stdin>:252:2: note: possible intended match here
 srai a0, a0, 31
 ^

Input file: <stdin>
Check file: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/CodeGen/RISCV/select-const.ll

-dump-input=help explains the following input dump.

```

</details>

https://github.com/llvm/llvm-project/pull/125772