[llvm] [XCOFF] print out symbol value name for llvm-readobj (PR #125861)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 6 01:05:42 PST 2025


https://github.com/jh7370 commented:

I'd suggest you change the PR title to something like the following:
"[XCOFF][llvm-readobj] Print symbol value kind when dumping symbols"

For the description, just include the second paragraph (the first paragraph just mirrors what the PR title says, so is redundant).

Should `symbols64.test` be updated in the same manner in this PR?

You've been somewhat inconsistent in which symbol classes you've tested the kind for. I'd suggest writing full coverage for the switch, so have highlighted the different things that need tackling, I believe.

https://github.com/llvm/llvm-project/pull/125861


More information about the llvm-commits mailing list