[llvm] [BOLT] Support computed goto and allow map addrs inside functions (PR #120267)

[Ash Dobrescu via llvm-commits]

================
@@ -2439,6 +2439,13 @@ void RewriteInstance::readDynamicRelocations(const SectionRef &Section,
     if (Symbol)
       SymbolIndex[Symbol] = getRelocationSymbol(InputFile, Rel);
 
+    const uint64_t SymAddress = SymbolAddress + Addend;
+    BinaryFunction *Func = BC->getBinaryFunctionContainingAddress(SymAddress);
+    if (Func && !Func->isInConstantIsland(SymAddress)) {
+      if (const uint64_t SymOffset = SymAddress - Func->getAddress())
+        Func->addEntryPointAtOffset(SymOffset);
+    }
----------------
Rin18 wrote:

>what happens if `Symbol` points to a function and `SymAddress` falls into another function?

I've added another check for this.


>What if the reference is in the constant island?

My understanding is that  `SymAddress` is the relocation reference here. In which case, there already is the `!Func->isInConstantIsland(SymAddress)` check which should make sure it's not in the constant island. Is there some other reference that you're referring to here? 

https://github.com/llvm/llvm-project/pull/120267