[llvm] [llvm-objdump][ELF]Fix crash when reading strings from .dynstr(#86612) (PR #125679)
Ruoyu Qiu via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 5 02:42:01 PST 2025
cabbaken wrote:
> > The new version of patch modified commit title ...
>
> The default behaviour for merging is to use the PR title and description, not the commit message (although the initial default of the PR title and description is taken from the commit message). If you need to update these, you should edit the PR, not the commit message.
>
> Also, please avoid force pushing after updating, as it makes it harder to see what has changed between versions of the PR.
>
> Finally, please add "Fixes: #86612" to the PR description. In that way, when the PR is merged, the issue should auto-close, I believe.
I've made the changes about the title and description of PR and will follow these guidelines in future work.
https://github.com/llvm/llvm-project/pull/125679
More information about the llvm-commits
mailing list