[llvm] [llvm-readobj][ELF][RISCV] Dump .note.gnu.property section contents (PR #125642)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 01:38:57 PST 2025


================
@@ -5441,7 +5464,8 @@ static std::string getGNUProperty(uint32_t Type, uint32_t DataSize,
 }
 
 template <typename ELFT>
-static SmallVector<std::string, 4> getGNUPropertyList(ArrayRef<uint8_t> Arr) {
+static SmallVector<std::string, 4> getGNUPropertyList(ArrayRef<uint8_t> Arr,
+                                                      uint16_t Target) {
----------------
jh7370 wrote:

The ELF term is "machine". Could we use that, please, to make it clearer this is referring to the EM_* values? Also, should the `uint16_t` use the actual ELF type for the e_machine field (i.e. `ELFT::Half`)?

https://github.com/llvm/llvm-project/pull/125642


More information about the llvm-commits mailing list