[llvm] [llvm-objcopy] Fix prints wrong path when section output path doesn't exist (PR #125345)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 01:26:40 PST 2025


================
@@ -1404,6 +1404,22 @@ inline Error createFileError(const Twine &F, size_t Line, std::error_code EC) {
   return createFileError(F, Line, errorCodeToError(EC));
 }
 
+/// Concatenate a source file path with a std::error_code and string error
----------------
jh7370 wrote:

Nit: Comments in LLVM require a trailing full stop ('.').

I also don't think this and the equivalent comment below make a huge amount of sense: you're not concatenating the file path with the `std::error_code` at all. Better would be to base the comment on the `createStringError` comments "Create a StringError with the specified error code and prepend the file path to it."

https://github.com/llvm/llvm-project/pull/125345


More information about the llvm-commits mailing list