[llvm] [llvm-objcopy] Fix prints wrong path when section output path doesn't exist (PR #125345)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 01:17:25 PST 2025


jh7370 wrote:

> Please take a final look when you have time @MaskRay @jh7370

Hi @AmrDeveloper,

The usual policy is to wait a week between an update and pinging for another review. Reviewers get email notifications when you update anyway, so we're typically aware that an updated review is needed, but for me at least, I only have time to do a limited amount of LLVM reviewing on a given day.

Also, [per LLVM policy](https://llvm.org/docs/GitHub.html#updating-pull-requests), please don't force push when making an update to the PR:
> When updating a pull request, you should push additional “fix up” commits to your branch instead of force pushing. This makes it easier for GitHub to track the context of previous review comments. Consider using the [built-in support for fixups](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---fixupamendrewordltcommitgt) in git.

Force pushes make it significantly harder to track what's changed between two versions of a patch and they're unnecessary - you can do fixup commits to address issues and if you need to rebase on main, you can generally use a merge commit from main (any merge commits and fixups will disappear when the PR is squashed and merged at the end).

I'll take a look at this PR again now.

https://github.com/llvm/llvm-project/pull/125345


More information about the llvm-commits mailing list