[lld] [llvm] [LLD][ELF][AArch64] Add support for SHF_AARCH64_PURECODE ELF section flag (3/3) (PR #125689)

[Csanád Hajdú via llvm-commits]

================
@@ -42,7 +42,8 @@ using namespace lld::elf;
 
 uint32_t OutputSection::getPhdrFlags() const {
   uint32_t ret = 0;
-  if (ctx.arg.emachine != EM_ARM || !(flags & SHF_ARM_PURECODE))
+  if ((ctx.arg.emachine != EM_ARM || !(flags & SHF_ARM_PURECODE)) &&
----------------
Il-Capitano wrote:

I wanted to separate out `SHF_ARM_*` and `SHF_AARCH64_*` in the code in order to not confuse the two architectures.
Adding `static_assert(SHF_ARM_PURECODE == SHF_AARCH64_PURECODE)`, and using only one of the flags in the condition could also work.

Other than the condition being more verbose like this being a downside, I think I have a weak preference for writing out the two flags explicitly, and not mixing different architectures.

https://github.com/llvm/llvm-project/pull/125689