[llvm] [AMDGPU][True16][MC] update vopc profile with AsmMatchConverter (PR #125561)

Ivan Kosarev via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 07:26:23 PST 2025


================
@@ -454,6 +454,11 @@ multiclass VOPCX_Pseudos <string opName,
     let isCommutable = 1;
     let SubtargetPredicate = HasNoSdstCMPX;
     let IsVCMPX = 1;
+    let AsmMatchConverter =
+        !if (P_NoSDst.HasOpSel, "cvtVOP3OpSel",
+            !if (!or(P_NoSDst.HasModifiers, P_NoSDst.HasOMod,
+                     P_NoSDst.HasIntClamp),
+                 "cvtVOP3", ""));
----------------
kosarev wrote:

Nit: could a `!cond()` be more readable here?

```suggestion
    let AsmMatchConverter = !cond(
        P_NoSDst.HasOpSel : "cvtVOP3OpSel",
        !or(P_NoSDst.HasModifiers, P_NoSDst.HasOMod, P_NoSDst.HasIntClamp) : "cvtVOP3",
        1 : "");
```

https://github.com/llvm/llvm-project/pull/125561


More information about the llvm-commits mailing list