[llvm] LAA: use make_early_inc_range to simplify code (NFC) (PR #125488)

[Ramkumar Ramachandra via llvm-commits]

================
@@ -3078,20 +3078,16 @@ const LoopAccessInfo &LoopAccessInfoManager::getInfo(Loop &L) {
   return *It->second;
 }
 void LoopAccessInfoManager::clear() {
-  SmallVector<Loop *> ToRemove;
   // Collect LoopAccessInfo entries that may keep references to IR outside the
   // analyzed loop or SCEVs that may have been modified or invalidated. At the
   // moment, that is loops requiring memory or SCEV runtime checks, as those cache
   // SCEVs, e.g. for pointer expressions.
-  for (const auto &[L, LAI] : LoopAccessInfoMap) {
+  for (const auto &[L, LAI] : make_early_inc_range(LoopAccessInfoMap)) {
----------------
artagnon wrote:

It doesn't erase any buckets:

```cpp
  bool erase(const KeyT &Val) {
    BucketT *TheBucket = doFind(Val);
    if (!TheBucket)
      return false; // not in map.

    TheBucket->getSecond().~ValueT();
    TheBucket->getFirst() = getTombstoneKey();
    decrementNumEntries();
    incrementNumTombstones();
    return true;
  }
```

make_early_inc_range stripped, thanks!

https://github.com/llvm/llvm-project/pull/125488